search

uwplse / herbgrind

A Valgrind tool for Herbie
GNU General Public License v3.0
90 stars 7 forks source link

Adding modf function #50

Closed hbrunie closed 4 years ago

hbrunie commented 4 years ago

Hi,

fmod and fmodf are both overloaded. Could modf and modff (or just modf as C++11 standard, modf) be added too?

Thanks

HazardousPeach commented 4 years ago

Hmm, from the documentation for these functions, they seem to produce two outputs, one in the normal return value, and one in an out parameter. I think I could add this, but it would be non-trivial as I haven't added any functions with out parameters yet; probably not going to get done right away (pull requests accepted!).

HazardousPeach commented 4 years ago

I finally got around to doing this! Should be fixed in 4770550