check if `git -C` is implemented

uwplse / herbgrind

A Valgrind tool for Herbie

GNU General Public License v3.0

90 stars 7 forks source link

check if `git -C` is implemented #59

Closed jose-d closed 4 years ago

jose-d commented 4 years ago

If herbgrind is being built on (latest) centos7, the system-default git doesn't support -C option. In the first make run it (correctly) fails, but in any following run it will just check presence of valgrind/README and then produce broken build without any warning.

can be reproduced with this git:

git-1.8.3.1-23.el7_8.x86_64

jose@koiosvm2:~/projects/herbgrind$ cat /etc/redhat-release 
CentOS Linux release 7.8.2003 (Core)
jose@koiosvm2:~/projects/herbgrind$

jose-d commented 4 years ago

continuous-integration/travis-ci/pr : All check have failed

I believe it's because of broken ppa, not because of the proposed patch:

...
The command "sudo add-apt-repository ppa:jonathonf/automake -y" failed and exited with 1 during .
...

HazardousPeach commented 4 years ago

Oh yeah, the CI seems broken right now... but anyway, thanks for the pull request! In this case, I figured it's pretty easy to use bash subshells instead, and still be able to support older versions of git, so I did that in feeb826 , now pushed to master.