Update rational_best for the herbie eval

uwplse / ruler

Rewrite Rule Inference Using Equality Saturation

https://dl.acm.org/doi/10.1145/3485496

MIT License

119 stars 9 forks source link

Update rational_best for the herbie eval #208

Closed oflatt closed 1 year ago

oflatt commented 1 year ago

This PR simplifies rational_best, which makes herbie perform better The branch is called "unsound" because the z3 verifier still allows dropping variables (which is unsound)

oflatt commented 1 year ago

Thanks for the review, fixed it up @ajpal

oflatt commented 1 year ago

Spoke too soon, need to fix up a test