uwreact / uwreact_robot

Software behind our fully autonomous FIRST robots
BSD 3-Clause "New" or "Revised" License
8 stars 6 forks source link

Add clang-format #64

Closed matthew-reynolds closed 5 years ago

matthew-reynolds commented 5 years ago

Pull Request

Closes #60

Duplicates changes from uwreact/frc_control#34 and uwreact/frc_control#35. This entails adding a clang-format config file, CI rules, and updating the README and PR template.

Contribution Checklist

Change Checklist

matthew-reynolds commented 5 years ago

Looks like the build is failing because our ROS version is still set to Kinetic in our CI config, which uses Ubuntu 16, which doesn't have clang-format-7 available. This CI config issue is addressed in #58, which is ready for merging. In future, I shouldn't have made that change in that PR, it should have been separate. However, since #58 is about to land anyways, let's just leave this PR until then rather than going back and breaking it out.

wmmc88 commented 5 years ago

Waiting on review from @michaelwm ?

wmmc88 commented 5 years ago

@Matthew-Reynolds update and merge?