Open matthew-reynolds opened 5 years ago
Elevating to urgent - This doesn't block any specific other issues or anything, but it's a fairly significant barrier to getting more collaborators involved. In particular, this must be done before our next recruiting round completes so that the new team members have a smoother experience joining the team.
Other things to add to the guide:
We should add that the body is optional, maybe change the imperative to "imperative or past-tense" since even though that's incorrect and inconsistent, it's more in line with how things are likely to be done. Idk I have mixed opinions on that last one.
Adding a couple examples of good commit messages might also be a good idea.
@michaelwm thoughts?
📖 Documentation Error
Our CONTRIBUTING.md is a bit confusing and doesn't do a good job of explaining that within-team members should contribute by creating branches within the main repo, as opposed to external contributors who should fork. Need to clarify this language.