uwreact / uwreact_robot

Software behind our fully autonomous FIRST robots
BSD 3-Clause "New" or "Revised" License
8 stars 6 forks source link

Update .clang-tidy #84

Closed ianjfrosst closed 5 years ago

ianjfrosst commented 5 years ago

Pull Request

Braces should be used everywhere. Not requiring braces around statements leads to problems with nested one-line for and if statements, for example.

Contribution Checklist

Change Checklist

wmmc88 commented 5 years ago

I back this

wmmc88 commented 5 years ago

Where is the issue for this @ianjfrosst?

matthew-reynolds commented 5 years ago

Closed in favor of #93.

Indentation is arguably much more important than braces for these issues, and indentation is already enforced. However, since there is disagreement on whether to braces should be required on single-line blocks, we'll err on the side of caution and require them everywhere.