uwreact / uwreact_robot

Software behind our fully autonomous FIRST robots
BSD 3-Clause "New" or "Revised" License
8 stars 6 forks source link

Switch from ros-shadow-fixed to ros-testing repo #85

Closed matthew-reynolds closed 5 years ago

matthew-reynolds commented 5 years ago

Pull Request

In the follow-up from the security issue on the ROS build farm last week, the ros-shadow-fixed repository has been replaced with the ros-testing repository.

Details here: https://discourse.ros.org/t/new-gpg-keys-deployed-for-packages-ros-org/9454

Note that industrial_ci has already updated their codebase upstream and have patched in a redirection from ros-shadow-fixed to ros-testing for people who are slow to update their configs (like us), which is why we haven't seen any issues yet.

Note also that, since we use the stereolabs/zed:ubuntu1804-cuda10.0-zed2.7 docker image rather than the stereolabs/zed:ubuntu1804-cuda10.0-zed2.7-ros image, we should still be okay with our docker image. Stereolabs still has not updated their docker images, so I suspect the -ros images will have the wrong GPG key for the ROS package servers, but we aren't using these so I believe we will face no issues here.

Contribution Checklist

Change Checklist

wmmc88 commented 5 years ago

Cancelled?

matthew-reynolds commented 5 years ago

All builds on this repo will fail until we land #86, so no point running the build.

matthew-reynolds commented 5 years ago

86 is landed, so this PR is unblocked now. Ready for review.