yapf changed its default behaviour recently. This causes some previously-conforming code to now fail to pass the linting rules. Normally, I would say this is a bad situation since a 3rd party dependency changed and affected our workflow, but I actually much prefer the new default that yapf uses, so I'm not too upset. It also brings the Python and C++ code styles closer to each other, so extra bonus (AllOnOneLineOrOnePerLine type of thing).
Note that this PR blocks all other PRs at the moment, since no code can land until our codebase and linters match up again.
Pull Request
yapfchanged its default behaviour recently. This causes some previously-conforming code to now fail to pass the linting rules. Normally, I would say this is a bad situation since a 3rd party dependency changed and affected our workflow, but I actually much prefer the new default thatyapfuses, so I'm not too upset. It also brings the Python and C++ code styles closer to each other, so extra bonus (AllOnOneLineOrOnePerLinetype of thing).Note that this PR blocks all other PRs at the moment, since no code can land until our codebase and linters match up again.
Contribution Checklist
Change Checklist