uwreact / uwreact_robot

Software behind our fully autonomous FIRST robots

BSD 3-Clause "New" or "Revised" License

8 stars 6 forks source link

Update linting #89

Closed matthew-reynolds closed 5 years ago

matthew-reynolds commented 5 years ago

Pull Request

Duplicate changes from uwreact/frc_control#75, uwreact/frc_control#76, and other incremental changes to improve linting rules and ROS conventions.

Contribution Checklist

[x] I have read the contributing guide.
[x] I have referenced relevant issues.
[x] I have labeled accordingly.
[x] I have detailed my changes as much as possible.

Change Checklist

[ ] I have added tests.
[x] I have added necessary documentation.
[x] I have auto formatted using clang-format or yapf.
[ ] I have tested my changes on real hardware.

matthew-reynolds commented 5 years ago

Blocked by #90, will rebase once #90 is merged

matthew-reynolds commented 5 years ago

After digging into this some more, it seems pylint does some weird things when a module only contains a single .py file. When there are other source files or submodules, the suppression of no-name-in-modules seems to work as expected, but when there are not, the behaviour is inconsistent and seems to be related to some weird caching thing. I don't fully understand it, but for the time being, the easiest solution is to just re-disable that pylint suppression. Once the package is more fleshed out, we can re-remove the suppression.

matthew-reynolds commented 5 years ago

@michaelwm @wmmc88 Build issues resolved, ready for re-review