uwreact / uwreact_robot

Software behind our fully autonomous FIRST robots

BSD 3-Clause "New" or "Revised" License

8 stars 6 forks source link

Update clang-tidy to force braces around bodies #93

Closed matthew-reynolds closed 5 years ago

matthew-reynolds commented 5 years ago

Pull Request

Replaces #84.

Require braces for all if, while, for, etc statements.

Since we were unable to reach a consensus on whether we should allow single-line blocks without braces, we will err on the side of caution and consistency and enforce all if and loop blocks must use braces.

Contribution Checklist

[x] I have read the contributing guide.
[x] I have referenced relevant issues.
[x] I have labeled accordingly.
[x] I have detailed my changes as much as possible.

Change Checklist

[ ] I have added tests.
[x] I have added necessary documentation.
[x] I have auto formatted using clang-format or yapf.
[ ] I have tested my changes on real hardware.