Make Welcome page respond better in desktop, mobile, and tablet views

uwrit / kpmp_ds

KPMP Discovery Service

https://uwrit.github.io/kpmp_ds/

BSD 3-Clause "New" or "Revised" License

1 stars 1 forks source link

Make Welcome page respond better in desktop, mobile, and tablet views #4

Closed mrose1202 closed 4 years ago

mrose1202 commented 4 years ago

See the attached screenshots for examples of how the info box and page is responding poorly on desktop, tablet, and mobile views.

welcome_tablet-view welcome_desktop-lg-screen-view welcome_mobile-view

Michael Rose rosemi@umich.edu

mh2727 commented 4 years ago

I have addressed these issues. Here is the link to test it: https://uwrit.github.io/kpmp_ds/

The changes should work on mobile, tablet, and web browsers.

mrose1202 commented 4 years ago

HI Mahadi -- I have to fail this. Sorry for not being more implicit before. This is the desired behavior and layout: (I did a quick screen grab and moved things around for this example.)

1) The NetID info section is meant to be displayed like this in "desktop" view at 1024 px width:

2) In an extended width view, the info section should retain its position:

3) In mobile/tablet view, the info section should stack just below the "remember me" check box:

Hope this helps. Email me if you have questions. (rosemi@umich.edu)

mrose1202 commented 4 years ago

@mh2727 : finished my QA. See my comment above. Thanks!

mh2727 commented 4 years ago

@mrose1202 : Updates have been made. Let me know if these pass. Thank you. https://uwrit.github.io/kpmp_ds/

mrose1202 commented 4 years ago

@mh2727 UX/QA: Pass -- Ship it! :)

beckysteck commented 4 years ago

@mh2727 This looks good to us. Feel free to close this issue now. (We don't have that ability.)