uwrit / leaf

Leaf Clinical Data Explorer
https://www.youtube.com/watch?v=ZuKKC7B8mHI
Other
88 stars 47 forks source link

Loading saved queries involves too many clicks #479

Open jnothman opened 2 years ago

jnothman commented 2 years ago

I would have expected that the Find Patients UI should make it easy to switch to a different query. Currently, however, it involves moving the mouse to several, quite small targets:

As long as "Run Query" is only available on the "Find Patients" page, it makes sense to have query loading accessible only from this page too, and to make the UI more accessible. Alternatively, run and load query should be straight on the nav bar.

I'd also suggest that clicking anywhere on the saved query row should open it, rather than needing to click "Open".

Also, clicking "Open" for the query currently being edited results in a no-op with no UI feedback. Perhaps "Open" should be renamed to "Current" as a simple fix. (But when I look at the code I am not certain how to make the queries.current.id state available to the SavedQueriesTable component, so perhaps a simpler fix would just be adding dispatch(setNoClickModalState({ message: "Already Loaded", state: NotificationStates.Complete })); before return here.

PS @ndobb, please lmk if I'm spamming you excessively or if this is helpful!

ndobb commented 2 years ago

As the saying goes, PRs are welcome 😉.

jnothman commented 2 years ago

I think this is a PR we could work up to ... Others seem more accessible!