Mark dataset date constraint visually

uwrit / leaf

Leaf Clinical Data Explorer

https://www.youtube.com/watch?v=ZuKKC7B8mHI

Other

86 stars 47 forks source link

Mark dataset date constraint visually #490

Closed jnothman closed 2 years ago

jnothman commented 2 years ago

Related to #489, this hopes to make it clearer to the user when they have selected a date range for an encounters-based dataset.

It displays like this:

Selecting "Anytime" will show as:

I do no currently have an icon for "At selected encounters" but obviously that can also be added.

ndobb commented 2 years ago

This looks excellent, @jnothman. Let me take a look and review but at a glance looks great.

jnothman commented 2 years ago

I should note that the CSS is a bit of a hack, so wider text looks like:

ndobb commented 2 years ago

@jnothman one small nitpick - for consistency can you please change the CSS names to hyphen-separated lowercase, rather than camelcase? Everything else looks solid and I'm happy to merge.

eg patientlist-column-selector-nameQualifier-dateBoundsAbbrev becomes patientlist-column-selector-name-qualifier-date-bounds-abbrev (or something similar)