search

uwrit / leaf

Leaf Clinical Data Explorer
https://www.youtube.com/watch?v=ZuKKC7B8mHI
Other
86 stars 47 forks source link

Implicit Conversion error #539

Closed nixj14 closed 1 year ago

nixj14 commented 2 years ago

Ran into implicit conversion errors issues when building (LeafDbDataReader.cs). Created a PR with a fix:

https://github.com/uwrit/leaf/pull/538

ndobb commented 1 year ago

Thanks @nixj14. Interestingly I think this may be a dotnet version issue (I suspect the C# compiler handles inference better in this case in more recent versions), per this conversation with our collaborators at Mount Sinai.

In any case I think the explicit conversion is a good idea anyway - thank you very much for making the PR. Merged!