uwrobotics / MarsRover2019-firmware

Firmware for UWRT Mars Rover 2019
1 stars 11 forks source link

Add ultrasonic sensor source code to /app (two files are currently the same) #27

Closed bradstevanus1 closed 5 years ago

jetkov commented 5 years ago

Sweet. Can you add the files types generated by your IDE to the .gitignore file?

bradstevanus1 commented 5 years ago

Ready to merge!

jetkov commented 5 years ago

Your IDE files are still showing up in the commit (https://github.com/uwrobotics/MarsRover2019-firmware/pull/27/files), can you untrack them and then commit that?

bradstevanus1 commented 5 years ago

I used git rm -r --cached . to remove and re-add all files for the .gitignore to take effect. Looks like the pull request is showed everything being removed and re-added.

jetkov commented 5 years ago

Thats ok since its a merge into your branch, go ahead and squash + merge. 👍 For PRs to master branch we should make sure they are pretty clear for everyone to see the intended changes.