uwrobotics / MarsRoverFirmware

Firmware for the University of Waterloo Rover Team URC Mars Rover
22 stars 57 forks source link

Update cmake to use mbed_create_distro and latest mbed release #404

Open wmmc88 opened 2 years ago

wmmc88 commented 2 years ago

This repo currently uses a fork of mbed feauture branch feature-cmake-object-libraries that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm).

According to discussion in https://github.com/ARMmbed/mbed-os/issues/13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in https://github.com/ARMmbed/mbed-os/pull/15126 instead.

We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use mbed_create_distro. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etc

0xc0170 commented 2 years ago

According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.

It would be the best to use mbed_create_distro. The feature branch is already way behind and it won't be integrated anytime soon. Did the feature branch work for you? i wonder how much effort it is to update to the latest release and use this create distro function instead.

wmmc88 commented 2 years ago

According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.

It would be the best to use mbed_create_distro. The feature branch is already way behind and it won't be integrated anytime soon. Did the feature branch work for you? i wonder how much effort it is to update to the latest release and use this create distro function instead.

The feature branch did work for us and I found it fairly painless to migrate to that feature branch ~9 months ago.

Not sure how much work it will be for us to go from the feature branch to using mbed_create_distro as I haven't looked too much into it, but its a low priority for us at the moment and probably won't be addressed for a while.

cindyli-13 commented 2 years ago

This repo currently uses a fork of mbed feauture branch feature-cmake-object-libraries that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm).

According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead.

We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use mbed_create_distro. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etc

The CAN patch was merged upstream actually in https://github.com/ARMmbed/mbed-os/pull/14612

wmmc88 commented 2 years ago

This repo currently uses a fork of mbed feauture branch feature-cmake-object-libraries that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm). According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead. We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use mbed_create_distro. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etc

The CAN patch was merged upstream actually in ARMmbed/mbed-os#14612

So we should be able to go back to using mainline mbed, right? no other patches we made that havent been upstreamed already?

cindyli-13 commented 2 years ago

This repo currently uses a fork of mbed feauture branch feature-cmake-object-libraries that was patched by me to pull in a fix for STM32 targets(which has since been officially released upstream), and then patched by @cindyli-13 to provide several can fixes(I don't think these fixes were merged upstream but @cindyli-13 can confirm). According to discussion in ARMmbed/mbed-os#13981, it seems like upstream mbed has gone a different direction and it looks like the feature-cmake-object-libraries is not going to be merged into mainline. Instead, it looks like mainline will be using the mbed_create_distro feature that merged in ARMmbed/mbed-os#15126 instead. We should probably pull in the latest official upstream release (patched with our can fixes), and port our repo to use mbed_create_distro. As it stands, our fw repo is using a version of mbed thats missing ~a years worth of bugfixes, features, etc

The CAN patch was merged upstream actually in ARMmbed/mbed-os#14612

So we should be able to go back to using mainline mbed, right? no other patches we made that havent been upstreamed already?

As far as I'm aware yes. Unless there were patches other than the CAN patch that aren't in mainline.