Firmware Training - Nihal Sahu

uwrobotics / MarsRoverFirmware

Firmware for the University of Waterloo Rover Team URC Mars Rover

22 stars 57 forks source link

Closed nihal-sahu closed 2 years ago

nihal-sahu commented 2 years ago

I've created a pull request so my CAN servo controller tutorial app can be reviewed.

nihal-sahu commented 2 years ago

I've implemented your comments @cindyli-13

nihal-sahu commented 2 years ago

@jahnavithota2011 Could you review my training?

jahnavithota2011 commented 2 years ago

@nihal-sahu I have added some comments on your PR.

jahnavithota2011 commented 2 years ago

Also, your clang format check seems to be failing, make sure to fix your file formats to pass the check.

nihal-sahu commented 2 years ago

@jahnavithota2011 I implemented your comments.

nihal-sahu commented 2 years ago

Thank you!