search

uws-eresearch / ADELTA

0 stars 0 forks source link

Show all images on item page #62

Closed ptsefton closed 10 years ago

ptsefton commented 10 years ago

Can you put an update here about what's involved in fixing this please Lloyd? What's the estimate to complete?

lloyd-h commented 10 years ago

This would probably involve UI changes to show images in a horizontal grid and when user clicks on an image, I thought of showing the image in a navigable lightbox. At the moment I am afraid it's difficult to give an estimate before looking at the code.

ptsefton commented 10 years ago

OK, important to have a look ASAP then

On Tue, Jul 29, 2014 at 2:33 PM, Lloyd H notifications@github.com wrote:

This would probably involve UI changes to show images in a horizontal grid and when user clicks on an image, I thought of showing the image in a navigable lightbox. At the moment I am afraid it's difficult to give an estimate before looking at the code.

— Reply to this email directly or view it on GitHub https://github.com/uws-eresearch/ADELTA/issues/62#issuecomment-50433628.

Peter Sefton +61410326955 pt@ptsefton.com http://ptsefton.com Gmail, Twitter & Skype name: ptsefton

Sarrasine commented 10 years ago

Would love to see what this looks like - thanks Lloyd!

Anna

Sent from my Samsung GALAXY S5 on the Telstra 4G network

-------- Original message -------- From: Peter Sefton Date:29/07/2014 3:37 PM (GMT+10:00) To: uws-eresearch/ADELTA Subject: Re: [ADELTA] Show all images on item page (#62)

OK, important to have a look ASAP then

On Tue, Jul 29, 2014 at 2:33 PM, Lloyd H notifications@github.com wrote:

This would probably involve UI changes to show images in a horizontal grid and when user clicks on an image, I thought of showing the image in a navigable lightbox. At the moment I am afraid it's difficult to give an estimate before looking at the code.

— Reply to this email directly or view it on GitHub https://github.com/uws-eresearch/ADELTA/issues/62#issuecomment-50433628.

Peter Sefton +61410326955 pt@ptsefton.com http://ptsefton.com Gmail, Twitter & Skype name: ptsefton

— Reply to this email directly or view it on GitHubhttps://github.com/uws-eresearch/ADELTA/issues/62#issuecomment-50436280.

lloyd-h commented 10 years ago

I've just added the new feature. Anna and Maria, could you please have a look and comment your feedback?

ptsefton commented 10 years ago

Looking good - main issue is some pics make the lightbox bigger than the viewing area. Please have a look and see if you can get it to go no larger than the viewport - spend no more than an hour.

lloyd-h commented 10 years ago

Now images are shown within the viewport.