uxDaniel / visa_rescheduler

US VISA (ais.usvisa-info.com) appointment re-scheduler - Colombian adaptation
288 stars 239 forks source link

Update to match latest version of appointment form #11

Closed orendon closed 2 years ago

orendon commented 2 years ago

I ran the script today and it was failing to reschedule, also I noticed the appointment form differs from the fields in the script, so I fixed it accordingly.

I was able to get an earlier appointment (from July to October) using this fix 🎉

Related to #7

uxDaniel commented 2 years ago

Hello @orendon! Thanks a lot for taking the time to submit a fix. Just out of curiosity, wouldn't this change make the scheduler work for the ASC appointments (biometrics, etc) instead of the Consulate one (interview, leave passport)?

orendon commented 2 years ago

@uxDaniel You might be right, I was required an interview in the past but not this time, so I'm not aware of the other kind of appointments. Prolly better to hold this PR until we do some further investigation, as this might be tailored to my specific use case

juanzgc commented 2 years ago

@uxDaniel Currently, is the scheduler providing appointments for ASC appointments and Consulate or at the moment is it only providing appointments for Consulate? It seems that the facility id is set to 25 which is only Consulate. Should I create a PR that checks if a reschedule requires both a Consulate and ASC update?

ASC = 26 Consulate = 25

It seems this PR had the right idea, of attempting to reschedule both. https://github.com/uxDaniel/visa_rescheduler/pull/2

uxDaniel commented 2 years ago

Absolutely, please go for it and we can review the PR. Thank you!