uxcam / react-native-ux-cam

54 stars 10 forks source link

Update minSdkVersion, RN version, and Android target SDK for compatibility with RN 0.71.14 #113

Closed WarleyLopes closed 1 year ago

WarleyLopes commented 1 year ago

While attempting to assemble AndroidTest from a Gradle build for a React Native project running on RN version 0.71.14, we encountered a conflict in the Android manifest merge. This conflict was due to the minimumSdkVersion of the react-native-ux-cam wrapper being set to 19, while the minimumSdkVersion for RN 0.71.14 is 21. Additionally, the build target for RN 0.71.14 is 33, not 32.

To resolve this issue, I have made the following changes locally to the react-native-ux-cam wrapper:

Updated the minimumSdkVersion to 21. Updated the React Native version to 0.71.14. Updated the Android target SDK version to 33.

After making these changes, I was able to successfully build our instrumented-tests APK referencing to my local fork as "react-native-ux-cam": "file:../react-native-ux-cam/uxcam-react-wrapper". I have tested these changes in our project and double-checked sessions are being uploaded to our uxcam dashboard, which gives me confidence to say everything looks like to be working as expected, so I am submitting these changes for review and integration into the main branch of the react-native-ux-cam repository, but I am not sure if more would be required on the actual uxcam repository is just a wrapper. And someone would need to pack and publish a new version to npm