search

uxcam / react-native-ux-cam

54 stars 10 forks source link

Improve README #49

Closed cameronnapoli closed 2 years ago

cameronnapoli commented 2 years ago

Without setting enableAdvancedGestureRecognizers to false on ios, drags are completely broken. I can't think of a single app that doesn't use dragging, and so I think it's important to have this.

I spent 15 hours trying to find this bug, and I'd like to keep other people from going through that pain 😅.

ankit-uxcam commented 2 years ago

Hey @cameronnapoli , thank you for this PR. Setting enableAdvancedGestureRecognizers to false in the app will hide all the touch events except single tap (eg. double tap, pan etc.) in the session dashboard. However there are some other gesture libraries that overlap with ours and the only option for those case is to set this property to false. For normal use case, the app should work fine without disabling this, so we suggest to disable it only if absolutely necessary. We tested dragging in our internal sample projects and drags were working fine even without disabling enableAdvancedGestureRecognizers. It would be really helpful for us if you could provide a simple project showing this issue so we could fix this issue if it exists.

cameronnapoli commented 2 years ago

It breaks PanResponder which is what I would consider a normal use case. I don't really have more time to put into this, but it seems UXCam is aware of the issue because it's noted in the type docs:

Screen Shot 2022-06-13 at 8 44 38 AM
ankit-uxcam commented 2 years ago

Hey @cameronnapoli , thank you for your feedback. We have updated the README to allow users to enable this feature in case they are facing issue with pan gesture. We have also added some other big improvements and fixes in this library that might be useful to you. So I am closing this PR right now. If you have any more issues, please feel free to contact us.

Thank you