uxlfoundation / oneAPI-spec

oneAPI Specification source files
https://spec.oneapi.com
Other
185 stars 107 forks source link

[OneMKL] [BLAS] data type of `transa` and `transb` in `gemm` and `gemv` #534

Closed vtavana closed 3 months ago

vtavana commented 5 months ago

Should oneapi::mkl::transpose be used instead of onemkl::transpose as the data type of transa and transb in gemm, gemm_batch, gemv, and gemv_batch? If yes, the change should be applied to all variants of each function.

For instance, here https://github.com/uxlfoundation/oneAPI-spec/blob/main/source/elements/oneMKL/source/domains/blas/gemm.rst?plain=1#L104

mmeterel commented 5 months ago

@vtavana Yes thanks for pointing is out. The namespaces needs to be updated in all relevant APIs. Feel free to open a pull request if you would like.

andrewtbarker commented 3 months ago

Fixed in #535