oneMKL build instruction improvements

uxlfoundation / open-source-working-group

The UXL Foundation Open Source Working Group

8 stars 4 forks source link

oneMKL build instruction improvements #38

Closed rodburns closed 2 weeks ago

rodburns commented 3 months ago

The build instructions for oneMKL could be clearer, in particular for the Nvidia and AMD backends but also for using an open source backend such as portBLAS. It would benefit the community if there was clearer information on the project README on how to build the project from source and link to different back end libraries. For example this PR outlines one of the improvements.

Acceptance Criteria:

Clear instructions for anyone to compile oneMKL from source with any of the available backends
Instructions have been reviewed by community members

Rbiessy commented 3 months ago

Note that we also started an open issue in https://github.com/oneapi-src/oneMKL/issues/459 We will probably start this work ourselves when we have the time but other contributions are more than welcome!

vbm23 commented 3 weeks ago

https://github.com/oneapi-src/oneMKL/pull/510 opened and waiting for 2nd review approval

vbm23 commented 2 weeks ago

https://github.com/oneapi-src/oneMKL/pull/510#event-13226021709 Merged https://github.com/oneapi-src/oneMKL/pull/490 Merged

vbm23 commented 2 weeks ago

@mkrainiuk Based on the above 2 MRs, would you consider this meets the acceptance criteria for this issue?

mkrainiuk commented 2 weeks ago

Yes, I think it was great improvement for the build instructions. I will close the task.