uxlfoundation / scikit-learn-intelex

Extension for Scikit-learn is a seamless way to speed up your Scikit-learn application
https://intel.github.io/scikit-learn-intelex/
Apache License 2.0
1.23k stars 176 forks source link

Set token permission for ci.yml #2162

Closed ethanglaser closed 3 weeks ago

ethanglaser commented 3 weeks ago

Description

Fix OpenSSF scan failure


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed. This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way. For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

Testing

icfaust commented 3 weeks ago

Anyone ever consider that "All CI jobs are green or I have provided justification why they aren't." is a perpetual loop?

napetrov commented 3 weeks ago

Anyone ever consider that "All CI jobs are green or I have provided justification why they aren't." is a perpetual loop?

i would say it's