uxlfoundation / scikit-learn-intelex

Extension for Scikit-learn is a seamless way to speed up your Scikit-learn application
https://intel.github.io/scikit-learn-intelex/
Apache License 2.0
1.23k stars 176 forks source link

ENH: Enable linear regression on GPU with non-PSD systems #2167

Closed david-cortes-intel closed 5 days ago

david-cortes-intel commented 2 weeks ago

Description

As a follow up from oneDAL PR: https://github.com/oneapi-src/oneDAL/pull/2976

Once that PR gets merged, this PR adds support here for the new cases of linear regression on GPU that it enables.

Checks are expected to be failing at the moment as the PR hasn't been merged yet.


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed. This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way. For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

Testing

Performance

Not applicable.

icfaust commented 2 weeks ago

@david-cortes-intel Looks good to me, when the other PR is merged, we can rebase this check for green and merge. Just ping me.

david-cortes-intel commented 1 week ago

Now waiting for the oneDAL version bump before this PR can be tested: https://github.com/oneapi-src/oneDAL/pull/2981

david-cortes-intel commented 1 week ago

/intelci: run

david-cortes-intel commented 1 week ago

/intelci: run

david-cortes-intel commented 6 days ago

All CI jobs passing now.