uxlfoundation / scikit-learn-intelex

Extension for Scikit-learn is a seamless way to speed up your Scikit-learn application
https://intel.github.io/scikit-learn-intelex/
Apache License 2.0
1.23k stars 176 forks source link

chore: refactor onedal interaction with backend and policies #2168

Open ahuber21 opened 2 weeks ago

ahuber21 commented 2 weeks ago

Description


PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed. This approach ensures that reviewers don't spend extra time asking for regular requirements.

You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way. For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).

Checklist to comply with before moving PR from draft:

PR completeness and readability

Testing

Performance

icfaust commented 2 weeks ago

i guess this contrasts the approach i wanted to take in #2158 . what i had not liked about _get_backend was the indirection it was inducing in accessing the pybind11 generated package, and hoped to bring native syntax back. maybe worth further discussion?

ahuber21 commented 2 weeks ago

/intelci: run

ahuber21 commented 2 weeks ago

/intelci: run

ahuber21 commented 2 weeks ago

/intelci: run

Alexsandruss commented 2 weeks ago

Check PR Checklist / Close all checkboxes before moving from draft (pull_request)

ahuber21 commented 1 week ago

Performance and accuracy are not affected image

ahuber21 commented 1 week ago

Reviewers, the performance regression in LogReg fit is reproducible and meaningful. I will investigate.

Performance degradation in LogReg is only compared to release (2025, 'P', 0), bot not main

image

--> It is not caused by this PR

ahuber21 commented 1 week ago

More checks required for SPMD changes, converting back to draft. But the non-SPMD contributions are still ready for review

ahuber21 commented 1 week ago

/intelci: run

ahuber21 commented 1 week ago

/intelci: run

ahuber21 commented 1 week ago

Working on removing _get_policy() and cleaning up dependencies on SYCL queues