Open ahuber21 opened 2 weeks ago
i guess this contrasts the approach i wanted to take in #2158 . what i had not liked about _get_backend was the indirection it was inducing in accessing the pybind11 generated package, and hoped to bring native syntax back. maybe worth further discussion?
/intelci: run
/intelci: run
/intelci: run
Check PR Checklist / Close all checkboxes before moving from draft (pull_request)
Performance and accuracy are not affected
Reviewers, the performance regression in LogReg fit is reproducible and meaningful. I will investigate.
Performance degradation in LogReg is only compared to release
(2025, 'P', 0), bot not main
--> It is not caused by this PR
More checks required for SPMD changes, converting back to draft. But the non-SPMD contributions are still ready for review
/intelci: run
/intelci: run
Working on removing _get_policy()
and cleaning up dependencies on SYCL queues
Description
@abstractmethod
and then populated using a decorator loaded from_backend.py
.self.infer(...)
rather than the convolutedself._get_backend("X", "Y", "infer" , ...)
.compute()
,infer()
, ...) on backend are unified in_backend.py
.Backend
wrapper class around the backend export inonedal/__init__.py
to reduce the use of global variables.BackendManager
,PolicyManager
,BackendFunction
that simplify interfacing with pybind/C++ backend functionality.I removed unused imports because there were so many in the files I touched. I didn't stop at the files I modified and did the entire repo, which messed up the diff a little. Sorry. I am constantly rebasing so that all functionality is in a single commit and you can look at the diff of this single commit instead if you want to review.PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed. This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way. For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing
Performance