PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed.
This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way.
For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
[x] I have reviewed my changes thoroughly before submitting this pull request.
[x] Git commit message contains an appropriate signed-off-by string (see CONTRIBUTING.md for details).
[x] I have resolved any merge conflicts that might occur with the base branch.
Testing
[x] All CI jobs are green or I have provided justification why they aren't.
ethanglaser
commented
1 day ago
Description
Minor follow-up to https://github.com/uxlfoundation/scikit-learn-intelex/pull/2167 and https://github.com/uxlfoundation/scikit-learn-intelex/pull/2154 with update to test_linear to align all overdetermined conditions.
Fixes public CI failure
PR should start as a draft, then move to ready for review state after CI is passed and all applicable checkboxes are closed. This approach ensures that reviewers don't spend extra time asking for regular requirements.
You can remove a checkbox as not applicable only if it doesn't relate to this PR in any way. For example, PR with docs update doesn't require checkboxes for performance while PR with any change in actual code should have checkboxes and justify how this code change is expected to affect performance (or justification should be self-evident).
Checklist to comply with before moving PR from draft:
PR completeness and readability
Testing