PDFDocument object conflicts with PDFKit.PDFDocument

uxmstudio / UXMPDFKit

An iOS PDF viewer and annotator written in Swift that can be embedded into any application.

MIT License

275 stars 104 forks source link

PDFDocument object conflicts with PDFKit.PDFDocument #71

Closed amosavian closed 7 years ago

amosavian commented 7 years ago

When I embed UXMPDFKit into my project, even without importing the framework in a particulat file, PDFDocument object inside library cause Xcode fails to import new PDFKit.PDFDocument and mark it as unavailable. I suggest renaming it to UXMPDFDocument to avoid ambiguity.

Your Environment

iOS Version: 11.0
Xcode Version: 9.0
Swift Version: 4.0

pushchris commented 7 years ago

@amosavian due to the introduction of PDFKit on iOS there is going to need to be a full re-write of the code to not conflict, remove redundant code and support features previously not implemented. That is something that is going to take quite a bit of time. I went ahead and namespaced the files in the swift-4.0 branch for the time being however.

amosavian commented 7 years ago

Thanks a lot ❤️