search

uxmstudio / UXMPDFKit

An iOS PDF viewer and annotator written in Swift that can be embedded into any application.
MIT License
274 stars 104 forks source link

UI layout fixes, improved flexibility, Swift 4.2 and more #94

Open rivera-ernesto opened 5 years ago

rivera-ernesto commented 5 years ago

• All changes from #83. • Allow setting UXMPDFViewController’s document after loading its view. • Make UXMPDFViewController’s collectionView and pageScrubber optionals only loaded after document is set. • Update to Swift 4.2. • Fix UXMThumbnailView layout. • Fix page number positioning. • New optional autoHidePageNumberTimeInterval. • Make autoSaveAction optional. • Make sure to call finishAnnotation() before showActivitySheet(). • Refactor saveToPDFFile with optional overwriteOriginal parameter. • Use adjustedContentInset to fix collection view layout warnings. • Call setNeedsLayout() instead of the not recommended layoutSubviews(). • Cleanup Example project. • Prevent crash when pdfDocRef's info is nil(#89).

Anyone can give it a try using pod 'UXMPDFKit', :git => 'https://github.com/codelathe/UXMPDFKit.git'.

rivera-ernesto commented 5 years ago

Updated PR.

rivera-ernesto commented 5 years ago

Added lots of crash fixes as we stress the library with our FileCloud app's 10k+ users.

ahelen commented 5 years ago

Hi, when will this request be merged so its possible to use version 0.7.3?

rivera-ernesto commented 5 years ago

Hi, when will this request be merged so its possible to use version 0.7.3?

You can use the fork in the mean time. See the PR description.