uxsolutions / bootstrap-datepicker

A datepicker for twitter bootstrap (@twbs)
Apache License 2.0
12.66k stars 6.08k forks source link

[BS4] problems with component input #1668

Open HallofFamer opened 8 years ago

HallofFamer commented 8 years ago

Well my site is being developed with bootstrap 4, I want to use the date picker but it doesnt work at all. I just include these files:

<link rel="stylesheet"  type="text/css" href="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-datepicker/1.5.0/css/bootstrap-datepicker.min.css"/>
<script type='text/javascript' src="https://cdnjs.cloudflare.com/ajax/libs/bootstrap-datepicker/1.5.0/js/bootstrap-datepicker.min.js">
<script type='text/javascript'>
$('.datepicker').datepicker()
</script>    

And the HTML I used was just copied/pasted from the documentation(the one with component/group):

<div class="input-group date">
    <input type="text" class="form-control datepicker" value="12-02-2012">
    <div class="input-group-addon">
        <i class="fa fa-calendar"></i>
    </div>
</div>

The only difference is that I replaced the span tag for glyphicon by fontawesome, other than this I dont see anything else that can cause the trouble. Is the issue caused by the removal of glyphicon? If so, when will you make this compatible with Bootstrap 4 which doesnt have glyphicon? Or am I doing something wrong myself?

acrobat commented 8 years ago

@HallofFamer bootstrap 4 is still in alpha and we currently don't have support for it. But should come we it reaches it final release!

HallofFamer commented 8 years ago

Oh so you dont support bootstrap 4? But I need it right now.

hebbet commented 8 years ago

read @acrobat's comment. We don't support it at the moment, as it is still an early alpha.

i would not use any alpha for a project

HallofFamer commented 8 years ago

read my comment. If you dont support it yet, then add the support now.

MrGeneric commented 8 years ago

Read my comment. You're being demanding and rude.

Johann-S commented 8 years ago

To see the evolution of the BS 4 support follow this issue : https://github.com/eternicode/bootstrap-datepicker/issues/1670

hebbet commented 8 years ago

then add the support now.

we maintain that proiect in our spare time. i don't think is useful to make changes for the current BS4 alpha, as they might change stuff during the development. as noted in #1670 we will add support during beta. until then BS4 is not supported by us.

if someone makes a PR, we might merge it.

hebbet commented 8 years ago

at least none normal input is working. Just tested with my BS4 playground.

with BS2 like css of datepicker image

with BS3 like css of datepicker image

i will change at least the title for clarification

jipexu commented 8 years ago

Hi I also use BS4 alpha.2 and in fact for now i really see only one problem with the placement of the calendar : always to high (and seems constant) .... so it seems that the calcul of the top property not work for BS 4 ... Is it right ? I think this problem can be fixed easily ... in a first time by an hard hack on the top property... I would like to fix this but not much time ... but i will try ... any help to start will be welcome ...

Thanks

And @ developpers thanks for this good pluggin !

hebbet commented 8 years ago

BS4 support is tracked at #1670

I will start updating as soon as an beta is available.