search

uxsolutions / bootstrap-datepicker

A datepicker for twitter bootstrap (@twbs)
Apache License 2.0
12.66k stars 6.07k forks source link

Cursor style for disabled dates #1887

Open nwhittaker opened 8 years ago

nwhittaker commented 8 years ago

Please consider the not-allowed cursor style for disabled dates.

acrobat commented 8 years ago

You can override the less or compiled css to achieve the different cursor style. Style is added here

Example:

.disabled:hover {
    cursor: not-allowed;
}
nwhittaker commented 8 years ago

Understood, I guess the crux of the issue is that .datepicker might be too generic a class name. I've got a datetime-picker[1] on the same page as this date-picker. And this cursor style is bleeding onto the datetime-picker's cursor style[2].

[1] https://github.com/Eonasdan/bootstrap-datetimepicker [2] https://github.com/Eonasdan/bootstrap-datetimepicker/blob/4.17.37/src/sass/_bootstrap-datetimepicker.scss#L212

acrobat commented 8 years ago

@nwhittaker Can you provide a jsfiddle example to show the issue?

nwhittaker commented 8 years ago

I'm not inclined to create a fiddle as it's kind of a complicated set-up w/ a fair number of dependencies to manually pull in. To address this particular issue, I don't expect a code change from you since it'd require changing the .datepicker class name which sounds like a major backwards compatibility break to me.

I guess just be aware that for sites needing more than one type of date picker, there's an increased risk of conflicts when choosing a CSS class name like .datepicker.

You also might consider rolling the "not-allowed" cursor change into your plugin as it does, IMO, provide a more usable UI/UX.