DefaultGoSourcePath assumes GOPATH is set

uxtoolkit / cog

The cog package provides functionality to develop reusable components (cogs) for Isomorphic Go web applications.

Other

9 stars 3 forks source link

DefaultGoSourcePath assumes GOPATH is set #1

Closed bketelsen closed 6 years ago

bketelsen commented 6 years ago

https://github.com/uxtoolkit/cog/blob/1925fd148fa51c11328b0c6d4667f7bdbca3c516/cog.go#L26

GOPATH is not required to be set since this change If the default GOPATH is used without setting GOPATH manually, this code fails. It would be better to check to see if GOPATH is set, if not, use build.Default.GOPATH from the go/build package.

EngineerKamesh commented 6 years ago

Thank you for the PR that resolved this issue.