Closed talha252 closed 6 years ago
Did you run the tests, do they still pass?
Not that it's critical but, are you using black and pygenstub, or are you handling these manually?
Only test_cli_version_should_print_version_number_and_exit
is failing right now but I don't think it is related to my changes.
I knew pygenstub previously, but I've just learned black. I reformatted the code with black.
Looks nice, merged. Thanks!
The version test doesn't fail on my setup.
Added your name to authors, feel free to change your entry in that file.
I think it fails because there is a conflict with my real env and the virtual env. Hope I figure it out soon. And thank you :)
Your name appears to be viii. Turgut Uyar
on that file. I am not sure if this is correct.
Fixed the author name.
For the test error, you might need to reinstall calico. If you are using "pip install -e ." or "python setup.py develop", try re-running it. I prefer "pip install -e .[dev,doc,test]", or better still, poetry. I will probably move project packaging to poetry.
I love Python, I love coding with it but when it comes to the packaging or managing dependencies, it is so frustrating to see that there are many faulty (or insufficient, or convoluted) tools. I don't know if it is me but I find it very agonizing to deal with these. By the way, I reinstall the Calico, now it seems to be working.
Hopefully, poetry will be the last tool for managing environments and packaging.
With this function, I think parsing a new attribute will be easier. The only drawback is that currently the validation function only takes one argument or no argument. I didn't want to complicate things by implementing multi-parameter validation function since at least one argument is sufficient for us.