search

uyar / calico

GNU General Public License v3.0
8 stars 4 forks source link

Make small corrections #8

Closed sahinakkaya closed 5 years ago

sahinakkaya commented 5 years ago

My IDE also shows a warning for val_func.

image

When I change the signature from Callable[[Any, ...], bool] to Callable[..., bool] no more warnings given. But I didn't include this change since you are giving at most 2 arguments to val_func . I tried Callable[[Any, Optional[Any]], bool] but it didn't work for some reason. So I left it as it is.

ghost commented 5 years ago

OK, nice contributions overall, thanks. Can you fix the trailing space issue? After that I'll merge your changes.

sahinakkaya commented 5 years ago

Actually I was trying to understand what are all these classes that are derived from Enum. So I copy pasted the code to an interpreter but it didn't work because of blank line after docstring. So I deleted it but then forgot to put it back. Sorry for this.

sahinakkaya commented 5 years ago

I will fix it when I'm on my computer. Hopefully this time I don't bring new errors.

ghost commented 5 years ago

No big deal. As I said, "black" can help you with this. Also, you can run "flake8 calico" to catch style issues. Or even better, install and run tox in the project directory to check whether everything is alright.

sahinakkaya commented 5 years ago

@uyaritu I fixed the issue about trailing spaces and decided to not delete the whitespace before colon at line 45 in parse.py as "black" suggests it: comment[len(delim) :].strip() You can edit my PR if you are uncomfortable with anything. Thanks.