Duplicate telegram and/or github not detected

[uyencfi]

The add command doesn't work as expected. It should not allow duplicate persons, but I can add a new student with a different name but same telegram and github as my own.

I think this situation is rare, because not many people want to steal the telegram and/or github username of other people. But there can be the case where 2 students have handles that are almost identical and the user made a typo when adding new person, resulting in duplicates.

[nus-se-script]

Team's Response

The duplicates are not allowed in the contacts list, but the user can be present in the contact list.

When the professor would provide you with a contacts list of all students in the mod, it would contain your details.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

• [x] I disagree

Reason for disagreement: If the app allows duplicates like that, the "Find a buddy" feature will rate this duplicate contact as having 100% similarity score. Now the user mistakenly thinks that this person has much in common with his/her own profile, but this may not be true.

When the professor would provide you with a contacts list of all students in the mod, it would contain your details.

I think this is a different issue. The file may include my own details when it is imported, and I understand why you want to allow duplicates when importing. But after importing, the app should not allow creating new contacts with the same information as myself, because this leads to the problem I pointed out above.

---