search

uyitroa / osr2mp4-core

A program to convert osu replay file osr to mp4. Sample: https://www.youtube.com/watch?v=5ugu_9yDSg0
MIT License
118 stars 14 forks source link

Stop changing global logging settings #65

Closed christopher-dG closed 3 years ago

christopher-dG commented 3 years ago

When I set up a Osr2mp4 instance with default kwargs, it changes a bunch of logging settings and seemingly turns the global logging level to DEBUG. Could we make this module use its own logger?

christopher-dG commented 3 years ago

I'm working around this by doing my own logging.basicConfig before creating any Osr2mp4 instances, which makes any subsequent calls do nothing. But I still think it would be good for this module to not use or configure the root logger.