search

uyjulian / spc2it

Convert SPC files to IT (Impulse Tracker) files
84 stars 10 forks source link

Segfaults on very large songs #1

Closed DaVince closed 9 years ago

DaVince commented 9 years ago

I just converted all Lufia 2 SPCs with the tool, and there was a single one it it wouldn't take. The file would process right up until the 100% mark and then segfault. My guess is that the song was too long to contain inside the IT file, as it contains the entire intro song of the game, which is around 6:50 long.

The file in question is 102 Rumbling.spc from the following archive: http://www.zophar.net/music/spc/lufia-ii-rise-of-the-sinistrals-[estpolis-denki-ii]-[lufia].html

The original OpenSPC would export approximately 6 minutes and 10 seconds of this song and then end. In other words, it saved an incomplete version of the song to IT rather than crashing.

uyjulian commented 9 years ago

I'll check that out.

DaVince commented 9 years ago

That fixed it, it exports now. But instead, there seems to be a new problem: the song ends at pattern 102; the rest of the patterns up to 206 just consist of complete silence. Pattern 206 itself contains the forced instrument stop commands. So it seems like the song has already long ended and yet still asks for more patterns for some reason.

uyjulian commented 9 years ago

Yeah, I'll check to trim the pattern later on.