search

uyuni-project / contrib

Collection of tools that are are not (yet!) officially part of the Uyuni product
8 stars 5 forks source link

Add reactivate proxy clients script #1

Closed aaannz closed 3 years ago

aaannz commented 3 years ago

Script to trigger bulk reactivations of proxy clients

aaannz commented 3 years ago

Overall I am lacking a bit of context, but the code should work. I would prefer meaningful name instead of one-letter variables as that would improve readability.

For context see https://bugzilla.suse.com/show_bug.cgi?id=1186471

I will address the rest of the issues in the evening.

aaannz commented 3 years ago

I found two minor things, but in general I think it's pretty straight forward and look fine. I haven't run the code so I trust that the sed does what it needs.

Thanks for review. It would be much easier to just use grains module, but that does not work when we have susemanager grain in the conf file. Hence the sed, but it was battle tested by one user reenabling over 700 clients.