search

uyuni-project / uyuni-tools

Tools to work with containerized Uyuni server
Apache License 2.0
13 stars 14 forks source link

Change --hubxmlrpc-enable to --hubxmlrpc-replicas #340

Closed nadvornik closed 1 month ago

nadvornik commented 1 month ago

What does this PR change?

Change mgradm install podman --hubxmlrpc-enable into --hubxmlrpc-replicas. Add support for hub xmlrpc container to mgradm scale. mgradm install --hubxmlrpc-replicas 0 does not install the service at all - I think we don't want to install it on standalone and peripheral servers.

Test coverage

Links

Issue(s): https://github.com/uyuni-project/uyuni-tools/issues/336

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

rjmateus commented 1 month ago

please check the PR from CoCo, and see how Kevin have work around the start|stop for the replicas. I think it can follow a similar approach: https://github.com/uyuni-project/uyuni-tools/pull/338

nadvornik commented 1 month ago

I have updated the PR with the coco changes https://github.com/uyuni-project/uyuni-tools/pull/338 and merged some code.