uyuni-project / uyuni-tools

Tools to work with containerized Uyuni server
Apache License 2.0
13 stars 14 forks source link

add podman >= 4.5.0 requirement for all distros #350

Closed mbussolotto closed 3 weeks ago

mbussolotto commented 1 month ago

What does this PR change?

see title. Tested here: https://build.opensuse.org/project/show/home:mbussolotto:branches:systemsmanagement:Uyuni:Master:ContainerUtils . So podman 4.5.0 is not available for:

Test coverage

Links

Issue(s): https://github.com/uyuni-project/uyuni/issues/8869

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

deneb-alpha commented 1 month ago

@mbussolotto please add a review for @raulillo82 . As a side note, if we force this change (that makes sense because we need podman4, not podman3), we have to clarify something also on the documentation from my POV. It could also be something to mention in the release notes.

mbussolotto commented 1 month ago

LGTM, but did you build for all distros just to make sure they all handle this syntax?

yep https://build.opensuse.org/project/show/home:mbussolotto:branches:systemsmanagement:Uyuni:Master:ContainerUtils