mgradm upgrade podman list doesn't should tags or error when not authenticated

uyuni-project / uyuni-tools

Tools to work with containerized Uyuni server

Apache License 2.0

14 stars 18 forks source link

mgradm upgrade podman list doesn't should tags or error when not authenticated #372

Closed rjmateus closed 2 months ago

rjmateus commented 3 months ago

When we run the command mgradm upgrade podman list without being authenticated we don't get any tags and it finishes with success. We should try to provide some insides in case the registry needs authentication to return the tags.

mbussolotto commented 2 months ago

it should be an easy fix, this part of code should be added in list function https://github.com/uyuni-project/uyuni-tools/blob/311105e2754979f2e7035fd8883f0e48631921b0/mgradm/shared/podman/podman.go#L339-L354

mbussolotto commented 2 months ago

I'll verify it on top of https://github.com/uyuni-project/uyuni-tools/pull/400, I think now just

authFile, cleaner, err := shared_podman.PodmanLogin()

would be enough