Closed nadvornik closed 3 months ago
This is a minimal change to implement the --registry flag behaviour as described in https://github.com/uyuni-project/uyuni-tools/issues/378 , except for default values.
The defaults are not changed - --image contains the registry and --registry is empty. This PR has an effect only if non-empty --registry is specified.
--image
--registry
Changing the defaults would require much more changes and testing.
Unit tests were added
[ ] DONE
Issue(s): https://github.com/uyuni-project/uyuni-tools/issues/378 https://github.com/SUSE/spacewalk/issues/24638 https://bugzilla.suse.com/show_bug.cgi?id=1226793
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)
changelog_test
Check How to branch and merge properly!
What does this PR change?
This is a minimal change to implement the --registry flag behaviour as described in https://github.com/uyuni-project/uyuni-tools/issues/378 , except for default values.
The defaults are not changed -
--image
contains the registry and--registry
is empty. This PR has an effect only if non-empty--registry
is specified.Changing the defaults would require much more changes and testing.
Test coverage
Unit tests were added
[ ] DONE
Links
Issue(s): https://github.com/uyuni-project/uyuni-tools/issues/378 https://github.com/SUSE/spacewalk/issues/24638 https://bugzilla.suse.com/show_bug.cgi?id=1226793
Changelogs
Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository
If you don't need a changelog check, please mark this checkbox:
If you uncheck the checkbox after the PR is created, you will need to re-run
changelog_test
(see below)Before you merge
Check How to branch and merge properly!