uyuni-project / uyuni-tools

Tools to work with containerized Uyuni server

Apache License 2.0

16 stars 19 forks source link

replace not working Fatal error by plain error return #397

Closed aaannz closed 4 months ago

aaannz commented 4 months ago

What does this PR change?

Calling Fatal().Err() is not enough without .Msg(), but instead just return error.

This also enables term and exec logging with trace log level.

Test coverage

No tests: add explanation
[X] DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/23774

[X] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

[ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

Bischoff commented 4 months ago

Thanks a lot Ondrej.