search

uyuni-project / uyuni-tools

Tools to work with containerized Uyuni server
Apache License 2.0
14 stars 18 forks source link

check and set IPv6 salt settings during migration (bsc#1227172) #399

Closed mbussolotto closed 2 months ago

mbussolotto commented 2 months ago

What does this PR change?

see title

Test coverage

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24711

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Before you merge

Check How to branch and merge properly!

mbussolotto commented 2 months ago

@cbosdo I haven't tested it, I'm going to do that now, but in the meanwhile it would be great if you think it's the right approach, thanks!

aaannz commented 2 months ago

Bug was at the end closed as invalid. And I tend to agree. With migration, we should not modify this config. People could have had ipv6 disabled intentionally, e.g. for lack of firewalling solution, etc.

With new install, that is different question.

cbosdo commented 2 months ago

Indeed, let's close it: it's dangerous