uyuni-project / uyuni

Source code for Uyuni
https://www.uyuni-project.org/
GNU General Public License v2.0
430 stars 180 forks source link

Missing margins in CVE audit #8758

Closed Etheryte closed 3 months ago

Etheryte commented 5 months ago

Part of https://github.com/SUSE/spacewalk/issues/18940

All urls below are specified as the dev proxy (yarn proxy https://...), since that's the most convenient way to work on these issues.

To switch between the new theme and the old theme in the console: debugUtils.toggleUpdatedTheme()
To switch between the Suma theme and the Uyuni theme: debugUtils.toggleTheme()


https://localhost:8080/rhn/manager/audit/cve

This page looks pretty okay otherwise, but some of the margins are missing so it ends up too cramped.

Old theme:

Screenshot 2024-05-16 at 17 42 29

New theme:

Screenshot 2024-05-16 at 17 42 34

Definition of done

The updated theme has no visual bugs, all related page urls are added to ViewHelper.java and view-helper.ts.

bisht-richa commented 3 months ago

Fixed: https://github.com/uyuni-project/uyuni/pull/8947