mcalmer commented 3 months ago

What does this PR change?

Currently we have 2 ways in the code how channels are changed.

One is changing the channels first in the Database and send it out to the client after it was changed.
The other way (new) we send the new channels out to the client first and only when the change was performed on the client successfully, we adapt the channels in the database.

The first (old) way has the benefit, that also offline clients change the channels and it can be changed on the client also later by just applying the channel state.

The 2nd way is complicated as new access tokens needs to be generated, but the channel pillar data needs to be manually compiled and send via the state.apply instead of using the standard way by reading the database. Offline minions will not change the channels at all which is a requirement of some users.

This PR try to go back to the 1st (old) way to just perform the changes in the Database and send out the result to the client. If that fail, we do not invalidate the tokens anymore as a new state.apply can fix the situation later.

For this we have to remove asynchronous handling of of things which were done in ChannelsChangeEventMessageAction as the following state.apply for the channels require to have the data in the database and this event is waiting on the main event to be finished. In this one case we execute now this Action Syncronous, while on Distupgrade and other cases we still use it via the message queue.

GUI diff

No difference.

[x] DONE

Documentation

No documentation needed: only internal and user invisible changes
[x] DONE

Test coverage

Unit tests were adapted
[x] DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/23251 Port(s): ???

[ ] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

[ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

[ ] Re-run test "changelog_test"
[ ] Re-run test "backend_unittests_pgsql"
[ ] Re-run test "java_pgsql_tests"
[ ] Re-run test "schema_migration_test_pgsql"
[ ] Re-run test "susemanager_unittests"
[ ] Re-run test "javascript_lint"
[ ] Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

github-actions[bot] commented 3 months ago

:wave: Hello! Thanks for contributing to our project. Acceptance tests will take some time (aprox. 1h), please be patient :coffee: You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8943/checks Once tests finish, if they fail, you can check :eyes: the cucumber report. See the link at the output of the action. You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8943/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking! :warning: You should not merge if acceptance tests fail to pass. :warning: