uyuni-project / uyuni

Source code for Uyuni

https://www.uyuni-project.org/

GNU General Public License v2.0

411 stars 171 forks source link

Improve viewport size check for mobile #8948

Open Etheryte opened 1 week ago

Etheryte commented 1 week ago

What does this PR change?

The old method was not reliable in all cases, using a media query should fix all the problems we had with it.

GUI diff

No difference.

[x] DONE

Documentation

No documentation needed: only internal and user invisible changes
[x] DONE

Test coverage

No tests: Small bugfix
[x] DONE

Links

[x] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

[x] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

[ ] Re-run test "changelog_test"
[ ] Re-run test "backend_unittests_pgsql"
[ ] Re-run test "java_pgsql_tests"
[ ] Re-run test "schema_migration_test_pgsql"
[ ] Re-run test "susemanager_unittests"
[ ] Re-run test "javascript_lint"
[ ] Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!