mackdk commented 1 week ago

What does this PR change?

This PR uses absolute paths when invoking commands to avoid using the PATH environment variable and thus avoid being subjected to possible environment injection attacks.

GUI diff

No difference.

[X] DONE

Documentation

No documentation needed: only internal and user invisible changes
[X] DONE

Test coverage

No tests: already covered
[X] DONE

Links

Issue(s): https://github.com/SUSE/spacewalk/issues/24387

[X] DONE

Changelogs

Make sure the changelogs entries you are adding are compliant with https://github.com/uyuni-project/uyuni/wiki/Contributing#changelogs and https://github.com/uyuni-project/uyuni/wiki/Contributing#uyuni-projectuyuni-repository

If you don't need a changelog check, please mark this checkbox:

[ ] No changelog needed

If you uncheck the checkbox after the PR is created, you will need to re-run changelog_test (see below)

Re-run a test

If you need to re-run a test, please mark the related checkbox, it will be unchecked automatically once it has re-run:

[ ] Re-run test "changelog_test"
[ ] Re-run test "backend_unittests_pgsql"
[ ] Re-run test "java_pgsql_tests"
[ ] Re-run test "schema_migration_test_pgsql"
[ ] Re-run test "susemanager_unittests"
[ ] Re-run test "javascript_lint"
[ ] Re-run test "spacecmd_unittests"

Before you merge

Check How to branch and merge properly!

github-actions[bot] commented 1 week ago

Suggested tests to cover this Pull Request

allcli_update_activationkeys
srv_create_repository
sle_ssh_minion
min_salt_migration
min_salt_install_with_staging
proxy_register_as_minion_with_script
min_deblike_salt
allcli_overview_systems_details
min_salt_formulas
min_project_lotus
srv_docker_cve_audit
minssh_move_from_and_to_proxy
min_salt_install_package
srv_monitoring
min_salt_openscap_audit
minkvm_guests
min_monitoring
min_recurring_action
min_salt_minion_details
min_rhlike_openscap_audit
srv_distro_cobbler
min_salt_minions_page
min_deblike_salt_install_package
min_empty_system_profiles
min_cve_id_new_syntax
min_ssh_tunnel
allcli_sanity
min_move_from_and_to_proxy
min_ansible_control_node
srv_power_management_redfish
min_bootstrap_script
min_rhlike_monitoring
allcli_software_channels_dependencies
min_cve_audit
min_salt_mgrcompat_state
min_config_state_channel
srv_reportdb
buildhost_bootstrap
minssh_salt_install_package
allcli_reboot
minssh_bootstrap_api
proxy_retail_pxeboot_and_mass_import
min_rhlike_salt_install_package_and_patch
min_deblike_monitoring
min_deblike_salt_install_with_staging
min_check_patches_install
srv_scc_user_credentials
srv_cobbler_distro
min_rhlike_salt
min_salt_lock_packages
srv_rename_hostname
proxy_branch_network
min_bootstrap_api
minssh_ansible_control_node
srv_first_settings
allcli_action_chain
min_salt_formulas_advanced
srv_cobbler_profile
srv_power_management
min_salt_user_states
allcli_config_channel
min_virthost
min_deblike_openscap_audit
min_action_chain
min_config_state_channel_subscriptions
min_timezone
buildhost_osimage_build_image
srv_advanced_search
min_activationkey
allcli_software_channels
min_bootstrap_reactivation
srv_maintenance_windows
min_salt_pkgset_beacon
proxy_as_pod_basic_tests
buildhost_docker_build_image
sle_minion
min_deblike_ssh
min_salt_software_states
min_rhlike_ssh
minssh_action_chain
min_custom_pkg_download_endpoint
allcli_system_group
proxy_cobbler_pxeboot
min_bootstrap_ssh_key
min_retracted_patches
min_change_software_channel
srv_datepicker
srv_custom_system_info
srv_check_sync_source_packages
srv_push_package
srv_delete_channel_from_ui
srv_check_channels_page
srv_virtual_host_manager
srv_clone_channel_npn
srv_handle_software_channels_with_ISS_v2
srv_manage_channels_page
min_bootstrap_negative
srv_channels_add
min_deblike_remote_command
srv_power_management_api
srv_logfile
srv_patches_page
srv_payg_ssh_connection
srv_user_configuration_salt_states
srv_group_union_intersection
srv_change_password
srv_users
srv_user_preferences
srv_menu_filter
srv_dist_channel_mapping
srv_disable_local_repos_off
srv_user_api
srv_manage_activationkey
srv_notifications
srv_docker_advanced_content_management
srv_change_task_schedule
srv_mainpage
min_rhlike_remote_command
srv_salt_download_endpoint
srv_check_reposync
srv_activationkey_api
srv_content_lifecycle
srv_cobbler_sync
srv_create_activationkey
srv_organization_credentials
buildhost_docker_auth_registry
srv_add_rocky8_repositories
srv_channel_api
srv_salt
min_config_state_channel_api
srv_cobbler_buildiso
srv_handle_config_channels_with_ISS_v2
srv_delete_channel_with_tool
min_docker_api
srv_restart
srv_sync_channels
srv_task_status_engine
srv_osimage
srv_enable_sync_products
srv_menu

github-actions[bot] commented 1 week ago

:wave: Hello! Thanks for contributing to our project. Acceptance tests will take some time (aprox. 1h), please be patient :coffee: You can see the progress at the end of this page and at https://github.com/uyuni-project/uyuni/pull/8952/checks Once tests finish, if they fail, you can check :eyes: the cucumber report. See the link at the output of the action. You can also check the artifacts section, which contains the logs at https://github.com/uyuni-project/uyuni/pull/8952/checks.

If you are unsure the failing tests are related to your code, you can check the "reference jobs". These are jobs that run on a scheduled time with code from master. If they fail for the same reason as your build, it means the tests or the infrastructure are broken. If they do not fail, but yours do, it means it is related to your code.

Reference tests:

KNOWN ISSUES

Sometimes the build can fail when pulling new jar files from download.opensuse.org . This is a known limitation. Given this happens rarely, when it does, all you need to do is rerun the test. Sorry for the inconvenience.

For more tips on troubleshooting, see the troubleshooting guide.

Happy hacking! :warning: You should not merge if acceptance tests fail to pass. :warning:

uyuni-project / uyuni

Avoid executing commands from path #8952