search

uyuni-project / virtual-host-gatherer

Script to gather information about virtual system running on different kind of hypervisors.
6 stars 13 forks source link

libvirt module support #23

Closed mbelur closed 2 years ago

moio commented 2 years ago

@cbosdo can you have a look and review this PR please?

mbelur commented 2 years ago

I am not really an expert in Virtual Host Gatherers, but from the libvirt side it seems good to me. Any reason to use a Virtual Host Gatherer given the Virtualization system property gives the same feature with many cool additions?

This work is to support using the virtual host gatherer to collect libvirt data independently of SUMA being deployed

mbelur commented 2 years ago

Please adapt also the spec file to create a sub package for libvirt: https://github.com/uyuni-project/virtual-host-gatherer/blob/master/virtual-host-gatherer/virtual-host-gatherer.spec

There are a lot of examples for all the other modules.

We are planning to update the spec as part of another PR. Let me know if that's okay.

mcalmer commented 2 years ago

We cannot merge until this is done. We do not want to have code in the git which ends up in the source package but is not in any binary package. It is ok if you want to do it in an extra PR, but we will merge only both together.

mbelur commented 2 years ago

We cannot merge until this is done. We do not want to have code in the git which ends up in the source package but is not in any binary package. It is ok if you want to do it in an extra PR, but we will merge only both together.

Updated the spec file in this PR.