search

uyuni-project / virtual-host-gatherer

Script to gather information about virtual system running on different kind of hypervisors.
6 stars 13 forks source link

Add gatherer for Xen server #9

Closed calancha closed 1 year ago

calancha commented 3 years ago

What does this PR change?

Add gatherer for Xen server

The following screenshots show:

suse-on-ubuntu-off-Screenshot from 2021-05-31 08-33-51

console-suse-on-ubuntu-off-Screenshot from 2021-05-31 08-37-28

suse-on-ubuntu-on-Screenshot from 2021-05-31 08-48-04

console-suse-on-ubuntu-on-Screenshot from 2021-05-31 08-50-01

Links

https://github.com/uyuni-project/uyuni/issues/3411

calancha commented 3 years ago

@agraul Regarding the port I am unsure what to do. Is it OK to use HTTP port 80 here?

paususe commented 3 years ago

@agraul Regarding the port I am unsure what to do. Is it OK to use HTTP port 80 here?

I think you should make the port configurable, defaulting to HTTPS on 443.

calancha commented 3 years ago

@agraul Regarding the port I am unsure what to do. Is it OK to use HTTP port 80 here?

I think you should make the port configurable, defaulting to HTTPS on 443.

Sure, it makes sense to use 443. I was just worry that I don't know how to enable it in my dev enviroment to check if it works.

paususe commented 3 years ago

@agraul Regarding the port I am unsure what to do. Is it OK to use HTTP port 80 here?

I think you should make the port configurable, defaulting to HTTPS on 443.

Sure, it makes sense to use 443. I was just worry that I don't know how to enable it in my dev enviroment to check if it works.

When I first looked into this, I used XCP-NG. You can use it with libvirt locally (not in PRV) if you enable nested virtualization on your machine. Alternatively, you can download the free version of XenServer but it's the same (just better SDK docs).

calancha commented 3 years ago

I think you should make the port configurable, defaulting to HTTPS on 443.

Sure, it makes sense to use 443. I was just worry that I don't know how to enable it in my dev enviroment to check if it works.

When I first looked into this, I used XCP-NG. You can use it with libvirt locally (not in PRV) if you enable nested virtualization on your machine. Alternatively, you can download the free version of XenServer but it's the same (just better SDK docs).

It works as you expected. The following screenshot is from a local xcp-ng:

after-trusted-self-signed-certificate-port-443-Screenshot from 2021-06-14 09-11-16

paususe commented 3 years ago

What are we missing here to merge?

agraul commented 3 years ago

What are we missing here to merge?

There are still two unresolved comments from my first review.

calancha commented 3 years ago

There are still two unresolved comments from my first review.

I will get back to them next week; sorry, I had a very busy week.

agraul commented 3 years ago

@calancha one thing we forgot until today, could you please add a changelog entry to virtual-host-gatherer/virtual-host-gatherer.changes at the top of the file, e.g.

- Add Xen gatherer module

-------------------------------------------------------------------
Sat Dec 05 13:13:42 CET 2020 - mc@suse.de
calancha commented 3 years ago

@calancha one thing we forgot until today, could you please add a changelog entry to virtual-host-gatherer/virtual-host-gatherer.changes at the top of the file, e.g.

- Add Xen gatherer module

-------------------------------------------------------------------
Sat Dec 05 13:13:42 CET 2020 - mc@suse.de

I have added the specification for the new module at virtual-host-gatherer.spec. If I am not woring, the entry in the changes file should appear automatically.

agraul commented 3 years ago

If I am not woring, the entry in the changes file should appear automatically.

I'm not aware of anything that would generate the changelog entry for the virtual-host-gatherer package. I'm probably missing something, do you know what's adding the entry @calancha ?

calancha commented 3 years ago

If I am not woring, the entry in the changes file should appear automatically.

I'm not aware of anything that would generate the changelog entry for the virtual-host-gatherer package. I'm probably missing something, do you know what's adding the entry @calancha ?

Probably you are right. I was imaging that maybe, the IBS somehow creates the entry after bulding the package. Let me confirm it with Julio.

calancha commented 3 years ago

I'm not aware of anything that would generate the changelog entry for the virtual-host-gatherer package. I'm probably missing aging that maybe, the IBS somehow creates the entry after bulding the package. Let me confirm it with Julio.

Added the changelog :-)

mbologna commented 3 years ago

Reminder: check how we can install xenapi python library dependency via Requires in specfile.

meaksh commented 2 years ago

As @agraul mentioned above, we do not have yet any python-XenAPI package at OBS/IBS. So the virtual-host-gatherer-Xen subpackage won't be installable in our SUSE/OpenSUSE distros.

Before merging this PR we would need to prepare this package, decide where to push it and if we really want to maintain it, and also fix the spec file so the Xen module is shipped by -Xen subpackage.

This would require we schedule some time to work on this, as Tino is not longer with us in the team.

/cc @admd

mcalmer commented 1 year ago

stalled PR - closing